This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Domains: deprecate domain.dispose(). #5021
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've already signed the CLA. |
|
All of the suggested changes have been incorporated into the PR -- anything else that needs to be done to get this accepted? |
|
What else needs to happen to nerf dispose, @isaacs? |
Follows @isaacs's recommendations in nodejs#5018. Includes some updates to documentation but not examples.
|
Squashed into a single commit, reworded commit message, rebased against master and force-pushed. |
| that set will be ignored. So, even if some remaining actions are still | ||
| in flight, Node.js will not communicate further about them. | ||
| ``` | ||
| Stability: 0 - Deprecated |
There was a problem hiding this comment.
I think this needs 4 spaces in front for it to be highlighted correctly.
|
@isaacs is there anything blocking this from going in? |
|
Landed on d86814a. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows @isaacs's recommendations in #5018. Includes some
updates to documentation but not examples.