This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Fixes #6309 and several related issues #6318
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for contributing this pull request! Here are a few pointers to make sure your submission will be considered for inclusion. Commit davepacheco/node@0f10e07 has the following error(s):
The following commiters were not found in the CLA:
You can fix all these things without opening another issue. Please see CONTRIBUTING.md for more information |
added 2 commits
October 7, 2013 13:17
This change makes several improvements to the ustack helper and MDB support: - ustack helper and MDB: add support for two-byte strings (necessary to print many filenames in stacktraces in 0.10 and later). - ustack helper: fix position numbers, which were off by a factor of two - ustack helper: fix frames with undefined Scripts (e.g., "RegExp") - ustack helper: add stub frames - MDB: add support for sliced strings - MDB: sync up with changes from the illumos version of the module
|
@tjfontaine I suppose you should review this PR and #6319? |
|
Thanks landed in 2b9e3fb with a slightly reworded commit message |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes several improvements to the ustack helper and MDB support:
(necessary to print many filenames in stacktraces in 0.10 and later).