This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
tls, crypto: add DHE support #8272
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (!bio) | ||
| return; | ||
|
|
||
| DH *dh = PEM_read_bio_DHparams(bio, NULL, NULL, NULL); |
|
@shigeki what's wrong with EDH ciphers? Other than a few nits - LGTM. |
|
@indutny Thanks for reviewing. It seems that |
|
And why do we need to disable them? |
|
I'm not sure the reason of the old commit. But it might come from prohibiting CBC by BEAST. |
|
Yeah, I already have a good cipher list for a v0.12. Let's remove |
shigeki
force-pushed
the
shigeki_20140827
branch
from
4dcb018
to
ba2affe
Compare
shigeki
pushed a commit
to shigeki/node-v0.x-archive
that referenced
this pull request
Aug 28, 2014
`!EDH` is also removed from the list in the discussion of nodejs#8272
|
@indutny The patch is revised with your comments. Also two changes are
Please review this again. |
added 2 commits
August 28, 2014 20:44
In case of an invalid DH parameter file, it is sliently discarded. To use auto DH parameter in a server and DHE key length check in a client, we need to wait for the next release of OpenSSL-1.0.2.
`!EDH` is also removed from the list in the discussion of nodejs#8272
shigeki
force-pushed
the
shigeki_20140827
branch
from
ba2affe
to
db29afb
Compare
|
LGTM, thank you! |
indutny
pushed a commit
that referenced
this pull request
Aug 28, 2014
`!EDH` is also removed from the list in the discussion of #8272 Reviewed-By: Fedor Indutny <fedor@indutny.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #8264, please review this, @indutny .
This also changes the default cipher list as
DHE-RSA-AES128-SHA256is added and!EDHis explicitly written to!EDH-RSA-DES:!EDH-DSS-DES.In case of an invalid DH parameter file, it is sliently discarded.
To use auto DH parameter in a server and DHE key length check in a client, we need to wait for the next release of OpenSSL-1.0.2.