This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
v8 2.28 for v0.12 #8524
Closed
v8 2.28 for v0.12 #8524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewed-By: Fedor Indutny <fedor@indutny.com>
- based on discarded v8 code
|
@refack erm? |
|
@indutny sorry, no offence intended. It's just that this is simpler to work with on MSVS (no second UV_loop and back and forth from JS to native on debugger communication). |
|
@refack it is good to have our own debug-agent. This is my point of view. The old v8's agent is using kind of it's own implementation of event loop anyway. |
|
I'm getting used to the current implementation... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main challenge was re-implementing DebuggerAgent.
This PR is based on my old work on
master(#8134) with allot of comments and guidance from @indutny and his #8476 PR.I believe this PR has a smaller foot print, thus lower impact on existing code, hence should cause minimal regressions on the
v0.12branch.