This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
docs: fix smalloc.dispose() example
#8625
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -48,6 +48,9 @@ possible options are listed in `smalloc.Types`. Example usage: | |||
|
|
|||
| // { '0': 0, '1': 0.1, '2': 0.2 } | |||
|
|
|||
| It is not possible to freeze, seal and prevent extensions of objects with external data using `Object.freeze`, | |||
Also couple of additions about `dispose` and limitations of smalloc'ed objects.
|
|
||
| After `dispose()` is called object still behaves as one with external data, for | ||
| example `smalloc.hasExternalData()` returns `true`. |
There was a problem hiding this comment.
It does make me sad V8 doesn't provide a way to remove this.
trevnorris
pushed a commit
that referenced
this pull request
Oct 27, 2014
Also couple of additions about dispose and limitations of smalloc'ed objects. Fixes: #8625 Reviewed-by: Trevor Norris <trev.norris@gmail.com>
|
Thanks much. Merged in 15aa47e. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also couple of additions about
disposeand limitations of smalloc'ed objects./cc @trevnorris