This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Update OpenSSL commands on TLS API docs to use best practices #8690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
Landed in ebf64b0, thank you! |
indutny
pushed a commit
to indutny/node
that referenced
this pull request
Nov 11, 2014
This updates key size to 2048 and default hash function to sha256. Reviewed-By: Fedor Indutny <fedor@indutny.com> PR-URL: nodejs#8690
indutny
pushed a commit
that referenced
this pull request
Nov 11, 2014
This updates key size to 2048 and default hash function to sha256. Reviewed-By: Fedor Indutny <fedor@indutny.com> PR-URL: #8690
mscdex
pushed a commit
to mscdex/node
that referenced
this pull request
Dec 25, 2014
This updates key size to 2048 and default hash function to sha256. Reviewed-By: Fedor Indutny <fedor@indutny.com> PR-URL: nodejs#8690
piscisaureus
pushed a commit
to piscisaureus/node2
that referenced
this pull request
Jan 10, 2015
This updates key size to 2048 and default hash function to sha256. Reviewed-by: Fedor Indutny <fedor@indutny.com> PR-URL: nodejs/node-v0.x-archive#8690 Cherry-picked-from: nodejs/node-v0.x-archive@88bd95c
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the suggested keysize to provide
opensslfrom 1024 to 2048, the current minimum acceptable keysize.It also adds the
-sha256flag to the CSR creation command, which will sign the CSR itself with SHA-256 instead of SHA-1. For at least a couple of CAs, this sends a signal to sign the resulting certificate with SHA-256 instead of SHA-1 (which is now heavily deprecated).