This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
http: verify http method is a valid http token #9076
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RFC 2616/7230 requires that http method conform to the token rule. This adds a check to verify that there are no invalid characters in the method. If there are, then we throw, otherwise fall through and continue. Replacement for nodejs#9017 based on feedback. Targeted at v0.10
|
cc @joyent/node-coreteam ... can we get a review on this one? does it still make sense to target this to v0.10 or should I rebase it on v0.12? |
|
@jasnell v0.10 is basically in maintenance, so unless this is a bug fix I'd just rebase on v0.12. |
|
+1... I suspected as much. Will rebase and resubmit. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC 2616/7230 requires that http method conform to
the token rule. This adds a check to verify that there are
no invalid characters in the method. If there are, then
we throw, otherwise fall through and continue.
Replacement for #9017 based on
feedback.
Targeted at v0.10
(I have a version targeted at v0.12 just in case).