Commits on Mar 26, 2015

1. test: Env variable to specify directory for pipes …

   At the uv layer pipes are connected with uv_pipe_connect.
   The current spec for this method indicates that the maximum
   length is limited to the size of length of
   sizeof(sockaddr_un.sun_path), typically between 92 and
   108 bytes. Anything longer than that just gets truncated.
   
   The simple testsuite currently creates pipes in directories
   under the directory where node was built.  In our jenkins
   jobs this sometimes ends up being a deep enough path that
   the path for the pipes is getting truncated.  The result
   is that tests using pipes fail with errors that don't
   make it obvious what the problem is.
   
   Even if the errors were helpful, we still need a way
   to avoid the truncation.
   
   This patch adds the environment variable NODE_PIPE_DIR.
   If set the tests create pipes in this directory instead of
   the current defaults.  In addition the test harness is
   updated to remove/delete this directory before/after
   each test is run.
   
   	modified:   test/common.js
   	modified:   test/simple/test-net-pipe-connect-errors.js
   	modified:   test/testpy/__init__.py
   	modified:   test/simple/test-cluster-eaccess.js

   

   mhdawson committed Mar 26, 2015
   Copy the full SHA

   64399dd View commit details

   Browse the repository at this point in the history