Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new v8 deprecation cause build failing #167

Closed
gengjiawen opened this issue Sep 11, 2020 · 1 comment
Closed

new v8 deprecation cause build failing #167

gengjiawen opened this issue Sep 11, 2020 · 1 comment

Comments

@gengjiawen
Copy link
Member

gengjiawen commented Sep 11, 2020 •
edited

Should be an easy fix

../src/node_file.cc:1940:59: error: 'IsExternal' is deprecated: Use String::IsExternalTwoByte() or String::IsExternalOneByte() [-Werror,-Wdeprecated-declarations]
    } else if (enc == UCS2 && IsLittleEndian() && string->IsExternal()) {
                                                          ^
../deps/v8/include/v8.h:3121:3: note: 'IsExternal' has been explicitly marked deprecated here
  V8_DEPRECATE_SOON(
  ^
../deps/v8/include/v8config.h:405:39: note: expanded from macro 'V8_DEPRECATE_SOON'
# define V8_DEPRECATE_SOON(message) [[deprecated(message)]]

Build log: https://github.com/nodejs/node-v8/runs/1084576984.
@vsemozhetbyt vsemozhetbyt mentioned this issue Sep 13, 2020
Closed
@gengjiawen gengjiawen mentioned this issue Sep 15, 2020
Merged
@gengjiawen
Copy link
Member Author

PR: nodejs/node#35204.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gengjiawen