Skip to content

Commit

Permalink
test: use destructuring and remove unused arguments
Browse files Browse the repository at this point in the history
Use destructuring consistently and remove unused function arguments in
test-pipewrap.js

PR-URL: #24375
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
  • Loading branch information
jkmdev authored and Trott committed Nov 17, 2018
1 parent c3a0337 commit 07a7bf7
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions test/async-hooks/test-pipewrap.js
Expand Up @@ -8,7 +8,7 @@ const assert = require('assert');
const tick = require('../common/tick'); const tick = require('../common/tick');
const initHooks = require('./init-hooks'); const initHooks = require('./init-hooks');
const { checkInvocations } = require('./hook-checks'); const { checkInvocations } = require('./hook-checks');
const spawn = require('child_process').spawn; const { spawn } = require('child_process');


if (!common.isMainThread) if (!common.isMainThread)
common.skip('Worker bootstrapping works differently -> different async IDs'); common.skip('Worker bootstrapping works differently -> different async IDs');
Expand Down Expand Up @@ -45,7 +45,7 @@ checkInvocations(processwrap, { init: 1 },
checkInvocations(x, { init: 1 }, 'pipe wrap when sleep.spawn was called'); checkInvocations(x, { init: 1 }, 'pipe wrap when sleep.spawn was called');
}); });


function onsleepExit(code) { function onsleepExit() {
checkInvocations(processwrap, { init: 1, before: 1 }, checkInvocations(processwrap, { init: 1, before: 1 },
'processwrap while in onsleepExit callback'); 'processwrap while in onsleepExit callback');
} }
Expand Down

0 comments on commit 07a7bf7

Please sign in to comment.