Permalink
Browse files

src: describe what NODE_MODULE_VERSION is for

Current comment described what to do with it when the ABI changes, but
implied that Node.js would load modules with newer ABI numbers, which it
will not.

PR-URL: #10414
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
  • Loading branch information...
1 parent 89fb822 commit 11ed8007df373721b6d464e38f19996c96f49f59 @sam-github sam-github committed with evanlucas Dec 22, 2016
Showing with 3 additions and 0 deletions.
  1. +3 −0 src/node_version.h
View
@@ -44,6 +44,9 @@
(minor) == NODE_MINOR_VERSION && (patch) <= NODE_PATCH_VERSION))
/**
+ * Node.js will refuse to load modules that weren't compiled against its own
+ * module ABI number, exposed as the process.versions.modules property.
+ *
* When this version number is changed, node.js will refuse
* to load older modules. This should be done whenever
* an API is broken in the C++ side, including in v8 or

0 comments on commit 11ed800

Please sign in to comment.