Skip to content

Commit

Permalink
test: fix test-trace-events-dns
Browse files Browse the repository at this point in the history
Test is using `common.fileExists()` which has been removed. There is no
need to check that the file exists as the attempt to read the file in
the next line will fail if the file does not exist. Remove existence
check.

PR-URL: #22674
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
  • Loading branch information
Trott authored and targos committed Sep 6, 2018
1 parent 032d886 commit 131d7e8
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions test/internet/test-trace-events-dns.js
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,6 @@ for (const tr in tests) {

const file = path.join(tmpdir.path, traceFile);

// Confirm that trace log file is created.
assert(common.fileExists(file));
const data = fs.readFileSync(file);
const traces = JSON.parse(data.toString()).traceEvents
.filter((trace) => trace.cat !== '__metadata');
Expand Down

0 comments on commit 131d7e8

Please sign in to comment.