Skip to content

Commit

Permalink
tools: set arch in Distribution.xml
Browse files Browse the repository at this point in the history
refs: #37678 (comment)

We overwrite the Distribution.xml file inside the pkg which means
the pkg cannot be opened on apple silicon without rosetta
as it defaults to x86_64

PR-URL: #38261
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
  • Loading branch information
Ash Cripps committed Apr 19, 2021
1 parent ee9e2a2 commit 13d0de5
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tools/macos-installer/productbuild/distribution.xml.tmpl
Expand Up @@ -6,7 +6,7 @@
<background alignment="topleft" file="osx_installer_logo.png"/>
<pkg-ref id="org.nodejs.node.pkg" auth="root"/>
<pkg-ref id="org.nodejs.npm.pkg" auth="root"/>
<options customize="allow" require-scripts="false"/>
<options customize="allow" require-scripts="false" hostArchitectures="x86_64,arm64"/>
<license file="license.rtf"/>
<choices-outline>
<line choice="org.nodejs.node.pkg" />
Expand Down

0 comments on commit 13d0de5

Please sign in to comment.