Skip to content
Permalink
Browse files

test: refactoring test with common.mustCall

PR-URL: #12702
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
  • Loading branch information...
weewey authored and addaleax committed Apr 28, 2017
1 parent 6058c43 commit 152966dbb5fc184a7cf12ce9e0ac0c0cbe8714d4
Showing with 13 additions and 10 deletions.
  1. +13 −10 test/parallel/test-https-simple.js
@@ -55,28 +55,31 @@ const serverCallback = common.mustCall(function(req, res) {

const server = https.createServer(options, serverCallback);

server.listen(0, function() {
server.listen(0, common.mustCall(() => {
// Do a request ignoring the unauthorized server certs
const port = server.address().port;

const noCertCheckOptions = {
hostname: '127.0.0.1',
port: this.address().port,
port: port,
path: '/',
method: 'GET',
rejectUnauthorized: false
};

noCertCheckOptions.Agent = new https.Agent(noCertCheckOptions);

const req = https.request(noCertCheckOptions, function(res) {
const req = https.request(noCertCheckOptions, common.mustCall((res) => {
let responseBody = '';
res.on('data', function(d) {
responseBody = responseBody + d;
});

res.on('end', function() {
res.on('end', common.mustCall(() => {
assert.strictEqual(responseBody, body);
testSucceeded();
});
});
}));
}));
req.end();

req.on('error', function(e) {
@@ -86,7 +89,7 @@ server.listen(0, function() {
// Do a request that throws error due to the invalid server certs
const checkCertOptions = {
hostname: '127.0.0.1',
port: this.address().port,
port: port,
path: '/',
method: 'GET'
};
@@ -102,11 +105,11 @@ server.listen(0, function() {
});
checkCertReq.end();

checkCertReq.on('error', function(e) {
checkCertReq.on('error', common.mustCall((e) => {
assert.strictEqual(e.code, 'UNABLE_TO_VERIFY_LEAF_SIGNATURE');
testSucceeded();
});
});
}));
}));

process.on('exit', function() {
assert.strictEqual(successful, tests);

0 comments on commit 152966d

Please sign in to comment.
You can’t perform that action at this time.