-
Notifications
You must be signed in to change notification settings - Fork 28.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fs: add type checking to makeCallback()
This commit adds proper type checking to makeCallback(). Anything other than undefined or a function will throw. PR-URL: #866 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Vladimir Kurchatkin <vladimir.kurchatkin@gmail.com>
- Loading branch information
Showing
2 changed files
with
32 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
var common = require('../common'); | ||
var assert = require('assert'); | ||
var fs = require('fs'); | ||
|
||
function test(cb) { | ||
return function() { | ||
// fs.stat() calls makeCallback() on its second argument | ||
fs.stat(__filename, cb); | ||
}; | ||
} | ||
|
||
// Verify the case where a callback function is provided | ||
assert.doesNotThrow(test(function() {})); | ||
|
||
// Passing undefined calls rethrow() internally, which is fine | ||
assert.doesNotThrow(test(undefined)); | ||
|
||
// Anything else should throw | ||
assert.throws(test(null)); | ||
assert.throws(test(true)); | ||
assert.throws(test(false)); | ||
assert.throws(test(1)); | ||
assert.throws(test(0)); | ||
assert.throws(test('foo')); | ||
assert.throws(test(/foo/)); | ||
assert.throws(test([])); | ||
assert.throws(test({})); |