Skip to content
Permalink
Browse files

test: fix test-net-connect-econnrefused (again)

test-net-connect-econnrefused was recently fixed, but only in certain
circumstances. This change allows it to succeed whether it is invoked
with `node` or `tools/test.py`. Makes sure no Socket handles are left,
which is what the test is trying to determine, rather than failing if
there are no handles of any kind left.

PR-URL: #25438
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
  • Loading branch information...
Trott authored and addaleax committed Jan 10, 2019
1 parent 5fe7741 commit 23d41fbf01b9992da720b917c0222dfc9a8111fc
Showing with 2 additions and 1 deletion.
  1. +2 −1 test/pummel/test-net-connect-econnrefused.js
@@ -50,7 +50,8 @@ function pummel() {
function check() {
setTimeout(function() {
assert.strictEqual(process._getActiveRequests().length, 0);
assert.strictEqual(process._getActiveHandles().length, 1); // the timer
const activeHandles = process._getActiveHandles();
assert.ok(activeHandles.every((val) => val.constructor.name !== 'Socket'));
check_called = true;
}, 0);
}

0 comments on commit 23d41fb

Please sign in to comment.
You can’t perform that action at this time.