Skip to content

Commit

Permalink
test: add regression test for #11257
Browse files Browse the repository at this point in the history
Refs: #11257

PR-URL: #20391
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
  • Loading branch information
Benjamin Coe authored and targos committed May 12, 2018
1 parent 3929516 commit 41e1dc0
Showing 1 changed file with 37 additions and 0 deletions.
37 changes: 37 additions & 0 deletions test/parallel/test-stdio-pipe-stderr.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
'use strict';
require('../common');
const tmpdir = require('../common/tmpdir');
const assert = require('assert');
const fs = require('fs');
const join = require('path').join;
const spawn = require('child_process').spawnSync;

// Test that invoking node with require, and piping stderr to file,
// does not result in exception,
// see: https://github.com/nodejs/node/issues/11257

tmpdir.refresh();
const fakeModulePath = join(tmpdir.path, 'batman.js');
const stderrOutputPath = join(tmpdir.path, 'stderr-output.txt');
// we need to redirect stderr to a file to produce #11257
const stream = fs.createWriteStream(stderrOutputPath);

// the error described in #11257 only happens when we require a
// non-built-in module.
fs.writeFileSync(fakeModulePath, '', 'utf8');

stream.on('open', () => {
spawn(process.execPath, {
input: `require("${fakeModulePath.replace(/\\/g, '/')}")`,
stdio: ['pipe', 'pipe', stream]
});
const stderr = fs.readFileSync(stderrOutputPath, 'utf8').trim();
assert.strictEqual(
stderr,
'',
`piping stderr to file should not result in exception: ${stderr}`
);
stream.end();
fs.unlinkSync(stderrOutputPath);
fs.unlinkSync(fakeModulePath);
});

0 comments on commit 41e1dc0

Please sign in to comment.