Skip to content
Permalink
Browse files

inspector: do not spin-wait while waiting for the initial connection

Fixes: #28741

PR-URL: #28756
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Aleksei Koziatinskii <ak239spb@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
  • Loading branch information...
eugeneo authored and Trott committed Jul 18, 2019
1 parent 6c288a7 commit 49144ab64d3c5810f70585c2ccb0c90539fec116
Showing with 1 addition and 2 deletions.
  1. +1 −2 src/inspector_agent.cc
@@ -699,8 +699,7 @@ class NodeInspectorClient : public V8InspectorClient {

MultiIsolatePlatform* platform = env_->isolate_data()->platform();
while (shouldRunMessageLoop()) {
if (interface_ && hasConnectedSessions())
interface_->WaitForFrontendEvent();
if (interface_) interface_->WaitForFrontendEvent();
while (platform->FlushForegroundTasks(env_->isolate())) {}
}
running_nested_loop_ = false;

0 comments on commit 49144ab

Please sign in to comment.
You can’t perform that action at this time.