child_process: inlines arg normalization in the fork function itself.

refs: #20749
nodejs · Aug 20, 2018 · 529480e · 529480e
1 parent 37d6019
commit 529480e
Showing 1 changed file with 7 additions and 15 deletions.
diff --git a/lib/child_process.js b/lib/child_process.js
@@ -58,7 +58,13 @@ function stdioStringToArray(option) {
   }
 }
 
-function normalizeForkArguments(args, options) {
+exports.fork = function fork(modulePath /* , args, options */) {
+  // Get options and args arguments.
+  var execArgv;
+
+  var args = arguments[1];
+  var options = arguments[2];
+
   if (Array.isArray(args)) {
     args = args.slice(0);
   } else if (options !== undefined &&
@@ -78,20 +84,6 @@ function normalizeForkArguments(args, options) {
     throw new ERR_INVALID_ARG_VALUE('options', 'object', options);
   }
 
-  return {
-    args,
-    options
-  };
-}
-
-exports.fork = function fork(modulePath /* , args, options */) {
-
-  // Get options and args arguments.
-  var execArgv;
-  var opts = normalizeForkArguments(arguments[1], arguments[2]);
-  var options = opts.options;
-  var args = opts.args;
-
   // Prepare arguments for fork:
   execArgv = options.execArgv || process.execArgv;