Skip to content
Permalink
Browse files
tty: refactor to avoid unsafe array iteration
PR-URL: #36771
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
  • Loading branch information
aduh95 authored and targos committed Jun 11, 2021
1 parent 0dea866 commit 716076e389e8ed9f8fea750c581996ab7f9fe258
Showing with 5 additions and 5 deletions.
  1. +4 −4 lib/internal/tty.js
  2. +1 −1 lib/tty.js
@@ -23,6 +23,7 @@
'use strict';

const {
ArrayPrototypeSome,
RegExpPrototypeTest,
StringPrototypeSplit,
StringPrototypeToLowerCase,
@@ -202,10 +203,9 @@ function getColorDepth(env = process.env) {
if (TERM_ENVS[termEnv]) {
return TERM_ENVS[termEnv];
}
for (const term of TERM_ENVS_REG_EXP) {
if (RegExpPrototypeTest(term, termEnv)) {
return COLORS_16;
}
if (ArrayPrototypeSome(TERM_ENVS_REG_EXP,
(term) => RegExpPrototypeTest(term, termEnv))) {
return COLORS_16;
}
}
// Move 16 color COLORTERM below 16m and 256
@@ -133,7 +133,7 @@ WriteStream.prototype._refreshSize = function() {
this.emit('error', errors.errnoException(err, 'getWindowSize'));
return;
}
const [newCols, newRows] = winSize;
const { 0: newCols, 1: newRows } = winSize;
if (oldCols !== newCols || oldRows !== newRows) {
this.columns = newCols;
this.rows = newRows;

0 comments on commit 716076e

Please sign in to comment.