Permalink
Browse files

os: use uv_os_gethostname() in hostname()

This commit changes the C++ implementation of os.hostname()
to use uv_os_gethostname().

PR-URL: #25111
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information...
cjihrig authored and MylesBorins committed Dec 18, 2018
1 parent ae50f48 commit add566eee58d26b6b8c8ace65d0fad42e570afdf
Showing with 5 additions and 8 deletions.
  1. +5 −8 src/node_os.cc
@@ -68,18 +68,15 @@ using v8::Value;
static void GetHostname(const FunctionCallbackInfo<Value>& args) {
Environment* env = Environment::GetCurrent(args);
char buf[MAXHOSTNAMELEN + 1];
size_t size = sizeof(buf);
int r = uv_os_gethostname(buf, &size);

if (gethostname(buf, sizeof(buf))) {
#ifdef __POSIX__
int errorno = errno;
#else // __MINGW32__
int errorno = WSAGetLastError();
#endif // __POSIX__
if (r != 0) {
CHECK_GE(args.Length(), 1);
env->CollectExceptionInfo(args[args.Length() - 1], errorno, "gethostname");
env->CollectUVExceptionInfo(args[args.Length() - 1], r,
"uv_os_gethostname");
return args.GetReturnValue().SetUndefined();
}
buf[sizeof(buf) - 1] = '\0';

args.GetReturnValue().Set(OneByteString(env->isolate(), buf));
}

0 comments on commit add566e

Please sign in to comment.