fixup! build: convert V8 test JSON to JUnit XML

nodejs · Jul 30, 2022 · bbff9b5 · bbff9b5
1 parent 1673df7
commit bbff9b5
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/Makefile b/Makefile
@@ -43,6 +43,9 @@ ifdef ENABLE_CONVERT_V8_JSON_TO_XML
 	TAP_V8_INTL_JSON := $(PWD)/v8-intl-tap.json
 	TAP_V8_BENCHMARKS_JSON := $(PWD)/v8-benchmarks-tap.json
 
+	# By default, the V8's JSON test output only includes the tests which have
+	# failed. We use --slow-tests-cutoff to ensure that all tests are present
+	# in the output, including those which pass.
 	TAP_V8 := --json-test-results $(TAP_V8_JSON) --slow-tests-cutoff 1000000
 	TAP_V8_INTL := --json-test-results $(TAP_V8_INTL_JSON) --slow-tests-cutoff 1000000
 	TAP_V8_BENCHMARKS := --json-test-results $(TAP_V8_BENCHMARKS_JSON) --slow-tests-cutoff 1000000

diff --git a/tools/v8-json-to-junit.py b/tools/v8-json-to-junit.py
@@ -1,4 +1,7 @@
 #!/usr/bin/env python
+# Large parts of this file are modified from
+# deps/v8/tools/testrunner/local/junit_output.py, which no longer exists in
+# latest V8.
 #
 # Copyright 2013 the V8 project authors. All rights reserved.
 # Redistribution and use in source and binary forms, with or without