Skip to content
Permalink
Browse files

test: set umask for tests

#25213 proposes setting umask in the
Python test runner to avoid spurious test failures when running from a
shell with a restrictive umask. This is a good idea, but will only fix
the issue for tests run with the Python runner. Set it in
`common/index.js` as well so that it fixes it even when tests are run
directly with a `node` binary, bypassing the Python test runner.

PR-URL: #25229
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information...
Trott authored and addaleax committed Dec 26, 2018
1 parent 3bebcf0 commit be16cc9fd6399cef5cb892e43a041852a39b8d7d
Showing with 8 additions and 0 deletions.
  1. +8 −0 test/common/index.js
@@ -34,6 +34,14 @@ const {
hasIntl
} = process.binding('config');

// Some tests assume a umask of 0o022 so set that up front. Tests that need a
// different umask will set it themselves.
//
// process.umask() is not available in workers so we need to check for its
// existence.
if (process.umask)
process.umask(0o022);

const noop = () => {};

const hasCrypto = Boolean(process.versions.openssl);

0 comments on commit be16cc9

Please sign in to comment.
You can’t perform that action at this time.