Skip to content

Commit

Permalink
repl: preserve preview on ESCAPE key press
Browse files Browse the repository at this point in the history
Fix: #46876
PR-URL: #46878
Fixes: #46876
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
  • Loading branch information
meixg authored and targos committed Mar 18, 2023
1 parent 8850dac commit d6a1232
Show file tree
Hide file tree
Showing 3 changed files with 25 additions and 6 deletions.
8 changes: 5 additions & 3 deletions lib/internal/repl/utils.js
Expand Up @@ -363,7 +363,7 @@ function setupPreview(repl, contextSymbol, bufferSymbol, active) {
}, () => callback(new ERR_INSPECTOR_NOT_AVAILABLE()));
}

const showPreview = () => {
const showPreview = (showCompletion = true) => {
// Prevent duplicated previews after a refresh.
if (inputPreview !== null || !repl.isCompletionEnabled) {
return;
Expand All @@ -379,8 +379,10 @@ function setupPreview(repl, contextSymbol, bufferSymbol, active) {
hasCompletions = false;

// Add the autocompletion preview.
const insertPreview = false;
showCompletionPreview(repl.line, insertPreview);
if (showCompletion) {
const insertPreview = false;
showCompletionPreview(repl.line, insertPreview);
}

// Do not preview if the command is buffered.
if (repl[bufferSymbol]) {
Expand Down
5 changes: 2 additions & 3 deletions lib/repl.js
Expand Up @@ -993,9 +993,8 @@ function REPLServer(prompt,
clearPreview(key);
if (!reverseSearch(d, key)) {
ttyWrite(d, key);
if (key.name !== 'escape') {
showPreview();
}
const showCompletionPreview = key.name !== 'escape';
showPreview(showCompletionPreview);
}
return;
}
Expand Down
18 changes: 18 additions & 0 deletions test/parallel/test-repl-history-navigation.js
Expand Up @@ -614,6 +614,24 @@ const tests = [
],
clean: false
},
{
// Test that preview should not be removed when pressing ESCAPE key
env: { NODE_REPL_HISTORY: defaultHistoryPath },
skip: !process.features.inspector,
test: [
'1+1',
ESCAPE,
ENTER,
],
expected: [
prompt, ...'1+1',
'\n// 2',
'\n// 2',
'2\n',
prompt,
],
clean: false
},
];
const numtests = tests.length;

Expand Down

0 comments on commit d6a1232

Please sign in to comment.