Skip to content

Commit

Permalink
deps: V8: backport aaacffa1e003
Browse files Browse the repository at this point in the history
Original commit message:

    PPC: skip all Simd tests on PPC

    As of https://crrev.com/c/2629465, Simd tests cannot pass on
    architectures without Simd support. Tests will need to be re-enabled
    once Simd support is fully implemented on PPC.

    Change-Id: I963639f1afa0c0ca7be3ca4b2fc06e874235b903
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2693056
    Reviewed-by: Zhi An Ng <zhin@chromium.org>
    Reviewed-by: Deepti Gandluri <gdeepti@chromium.org>
    Commit-Queue: Milad Fa <mfarazma@redhat.com>
    Cr-Commit-Position: refs/heads/master@{#72788}

Refs: v8/v8@aaacffa

PR-URL: #38273
Backport-PR-URL: #38991
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
  • Loading branch information
targos committed Jun 14, 2021
1 parent 1a7c8a1 commit eac377b
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 1 deletion.
2 changes: 1 addition & 1 deletion common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.5',
'v8_embedder_string': '-node.6',

##### V8 defaults for Node.js #####

Expand Down
5 changes: 5 additions & 0 deletions deps/v8/test/message/message.status
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,11 @@
}],

################################################################################
['arch == ppc64', {
# Tests that require Simd enabled.
'wasm-trace-memory': [SKIP],
}],

['arch == mips64el or arch == mipsel', {
# Tests that require Simd enabled.
'wasm-trace-memory': [SKIP],
Expand Down
4 changes: 4 additions & 0 deletions deps/v8/tools/testrunner/base_runner.py
Original file line number Diff line number Diff line change
Expand Up @@ -654,6 +654,10 @@ def _get_statusfile_variables(self, options):
self.build_config.arch == 'mipsel':
no_simd_sse = not simd_mips

# Set no_simd_sse on architectures without Simd enabled.
if self.build_config.arch == 'ppc64':
no_simd_sse = True

return {
"arch": self.build_config.arch,
"asan": self.build_config.asan,
Expand Down

0 comments on commit eac377b

Please sign in to comment.