Skip to content

Commit

Permalink
module: avoid passing unnecessary loop reference
Browse files Browse the repository at this point in the history
It's a sync request, which doesn't require the loop parameter to be set.

PR-URL: #29275
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
saghul authored and BridgeAR committed Sep 3, 2019
1 parent 65de900 commit eb2d96f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/module_wrap.cc
Original file line number Diff line number Diff line change
Expand Up @@ -462,7 +462,7 @@ std::string ReadFile(uv_file file) {
uv_buf_t buf = uv_buf_init(buffer_memory, sizeof(buffer_memory));

do {
const int r = uv_fs_read(uv_default_loop(),
const int r = uv_fs_read(nullptr,
&req,
file,
&buf,
Expand Down

0 comments on commit eb2d96f

Please sign in to comment.