Skip to content

Commit

Permalink
http: explain the possibilty of refactor unused argument
Browse files Browse the repository at this point in the history
PR-URL: #37275
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
  • Loading branch information
Ayase-252 authored and danielleadams committed Feb 16, 2021
1 parent d63ac28 commit f5d1bf9
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions lib/_http_incoming.js
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,10 @@ IncomingMessage.prototype.setTimeout = function setTimeout(msecs, callback) {
// argument adaptor frame creation inside V8 in case that number of actual
// arguments is different from expected arguments.
// Ref: https://bugs.chromium.org/p/v8/issues/detail?id=10201
// NOTE: Argument adapt frame issue might be solved in V8 engine v8.9.
// Refactoring `n` out might be possible when V8 is upgraded to that
// version.
// Ref: https://v8.dev/blog/v8-release-89
IncomingMessage.prototype._read = function _read(n) {
if (!this._consuming) {
this._readableState.readingMore = false;
Expand Down

0 comments on commit f5d1bf9

Please sign in to comment.