Skip to content
Browse files
tools: make utils.SearchFiles deterministic
`glob.glob` on Linux returns files in the order returned by the
filesystem driver, and the output from this function is stuffed by
the Electron build process straight into the `config.gypi` header,
causing non-reproducible builds.

See this log for an example of the nondeterminism:

PR-URL: #44496
Reviewed-By: Luigi Pinca <>
Reviewed-By: Tobias Nießen <>
Reviewed-By: Richard Lau <>
Reviewed-By: Stewart X Addison <>
  • Loading branch information
brjsp authored and danielleadams committed Oct 10, 2022
1 parent d762a34 commit fd99b17a4de959ab10f85d0901605dcf74c8706f
Showing 1 changed file with 1 addition and 1 deletion.
@@ -112,4 +112,4 @@ def SearchFiles(dir, ext):
list = glob.glob(dir+ '/**/*.' + ext, recursive=True)
if sys.platform == 'win32':
list = [ x.replace('\\', '/')for x in list]
return list
return sorted(list)

0 comments on commit fd99b17

Please sign in to comment.