tools: make utils.SearchFiles deterministic #44496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
build
lpinca
approved these changes
Sep 2, 2022
github-actions
bot
removed
the
request-ci
richardlau
approved these changes
Sep 5, 2022
richardlau
added
request-ci
|
@brjsp Would you mind force-pushing the same commit with an amended commit message that adheres to the commit message guidelines? |
`glob.glob` on Linux returns files in the order returned by the filesystem driver, and the output from this function is stuffed by the Electron build process straight into the `config.gypi` header, causing non-reproducible builds. See this log for an example of the nondeterminism: https://rb.zq1.de/compare.factory-20220901/diffs/nodejs-electron-compare.out
|
@tniessen done |
github-actions
bot
removed
the
request-ci
This was referenced Sep 6, 2022
github-actions
bot
removed
the
request-ci
sxa
approved these changes
Oct 4, 2022
There was a problem hiding this comment.
Is the function used guaranteed to be deterministic or can it be influenced by the locale setting on the machine? Either way, this will at least allow a build environment with a documented, fixed, locale to produce deterministic output, so I'm happy to approve, although there could be a small performance overhead by doing this frequently on larger directories.
richardlau
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in e2ca29f |
|
@sxa the default string comparator in Python sorts by codepoint value, ignoring any locale settings. |
danielleadams
pushed a commit
that referenced
this pull request
Oct 11, 2022
`glob.glob` on Linux returns files in the order returned by the filesystem driver, and the output from this function is stuffed by the Electron build process straight into the `config.gypi` header, causing non-reproducible builds. See this log for an example of the nondeterminism: https://rb.zq1.de/compare.factory-20220901/diffs/nodejs-electron-compare.out PR-URL: #44496 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Stewart X Addison <sxa@redhat.com>
Merged
richardlau
added
lts-watch-v14.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
glob.glob on Linux returns files in the order returned by the filesystem driver,
and the output from this function is stuffed by the Electron build process
straight into the config.gypi header, causing non-reproducible builds.
See this log for an example of the nondeterminism:
https://rb.zq1.de/compare.factory-20220901/diffs/nodejs-electron-compare.out