Skip to content

Commit

Permalink
test: remove the third string literal argument from assert.strictEqual()
Browse files Browse the repository at this point in the history
Third string literal argument in assert.strictEqual() needs to be
removed. Otherwise, on AssertionError it would not display the
values that failed the check -- this hinders debugging.
The string literals are added as comments above the check.

PR-URL: #21406
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
  • Loading branch information
kevintab95 authored and Trott committed Jun 20, 2018
1 parent e43d91c commit fea3595
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions test/parallel/test-string-decoder-end.js
Expand Up @@ -103,8 +103,10 @@ function testBuf(encoding, buf) {
// .toString() on the buffer
const res3 = buf.toString(encoding);

assert.strictEqual(res1, res3, 'one byte at a time should match toString');
assert.strictEqual(res2, res3, 'all bytes at once should match toString');
// One byte at a time should match toString
assert.strictEqual(res1, res3);
// All bytes at once should match toString
assert.strictEqual(res2, res3);
}

function testEnd(encoding, incomplete, next, expected) {
Expand Down

0 comments on commit fea3595

Please sign in to comment.