Skip to content

Commit

Permalink
test: http2 priority stream depends on itself
Browse files Browse the repository at this point in the history
This commit add test case where priority() throws ERR_INVALID_OPT_VALUE
when stream depends on itself

Refs: #14985
PR-URL: #16224
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
trivikr authored and mcollina committed Oct 17, 2017
1 parent c9da05d commit ff747e3
Showing 1 changed file with 57 additions and 0 deletions.
57 changes: 57 additions & 0 deletions test/parallel/test-http2-priority-parent-self.js
@@ -0,0 +1,57 @@
'use strict';

const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const h2 = require('http2');

const server = h2.createServer();
const invalidOptValueError = (value) => ({
type: TypeError,
code: 'ERR_INVALID_OPT_VALUE',
message: `The value "${value}" is invalid for option "parent"`
});

// we use the lower-level API here
server.on('stream', common.mustCall((stream) => {
common.expectsError(
() => stream.priority({
parent: stream.id,
weight: 1,
exclusive: false
}),
invalidOptValueError(stream.id)
);
stream.respond({
'content-type': 'text/html',
':status': 200
});
stream.end('hello world');
}));

server.listen(0, common.mustCall(() => {

const client = h2.connect(`http://localhost:${server.address().port}`);
const req = client.request({ ':path': '/' });

req.on(
'ready',
() => common.expectsError(
() => req.priority({
parent: req.id,
weight: 1,
exclusive: false
}),
invalidOptValueError(req.id)
)
);

req.on('response', common.mustCall());
req.resume();
req.on('end', common.mustCall(() => {
server.close();
client.destroy();
}));
req.end();

}));

0 comments on commit ff747e3

Please sign in to comment.