Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

https: certificate validation fails when using servername option #1106

Closed
skenqbx opened this issue Mar 9, 2015 · 3 comments
Closed

https: certificate validation fails when using servername option #1106

skenqbx opened this issue Mar 9, 2015 · 3 comments
Labels
confirmed-bug Issues with confirmed bugs. https Issues or PRs related to the https subsystem.

Comments

@skenqbx
Copy link
Contributor

skenqbx commented Mar 9, 2015

Agent#createSocket() overwrites options.servername leading to a tls.checkServerIdentity() against hostname instead of servername.

I usually disabled connection pooling in that case, but that is not possible anymore as ClientRequest#constructor always sets an agent.

Not sure if this is intentional; Did I overlook something in the changelog?

@skenqbx
Copy link
Contributor Author

skenqbx commented Mar 9, 2015

I provide a PR incl. test for Agent#createSocket() when I get the go ahead.

@bnoordhuis
Copy link
Member

/cc @indutny - seems like an unambiguous bug to me..

@mscdex mscdex added confirmed-bug Issues with confirmed bugs. https Issues or PRs related to the https subsystem. labels Mar 9, 2015
@indutny
Copy link
Member

indutny commented Mar 9, 2015

Surely a bug, @skenqbx please go ahead ;) Please submit a test first, though. Just to make sure that we are on the same page.

@skenqbx skenqbx closed this as completed Mar 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed-bug Issues with confirmed bugs. https Issues or PRs related to the https subsystem.
Projects
None yet
Development

No branches or pull requests

4 participants