https: fix agent servername option #1110
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, is this actually https only though? cc @indutny |
|
@Fishrock123 The |
|
Will look into it later, please don't land yet ;) (later = 10-12 hours) On Tuesday, March 10, 2015, Malte-Thorben Bruns notifications@github.com
|
|
Took 16 hours, but finally looking into it. |
|
I'm not sure what kind of semver tag should it have... Seems to be a bugfix, but is a behaviour change too. cc @Fishrock123 @rvagg ? |
indutny
pushed a commit
that referenced
this pull request
Mar 11, 2015
PR-URL: #1110 Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
|
Landed in 8453fbc, thank you! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1106 for original issue.
As requested; the test first.
This PR also need to be ported to node v0.12 & v0.10