Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async listener removal also drops tracing #123

Closed
piscisaureus opened this issue Dec 9, 2014 · 3 comments
Closed

Async listener removal also drops tracing #123

piscisaureus opened this issue Dec 9, 2014 · 3 comments

Comments

@piscisaureus
Copy link
Contributor

I was trying to merge @trevnorris' asynclister removal (#124) but I noticed that require('tracing').v8 had also been removed. Is this desired?

@trevnorris @bnoordhuis

@bnoordhuis
Copy link
Member

IIRC, @trevnorris and I agreed to move the v8 stuff to a separate v8 module. I'll file a PR when #124 lands.

@trevnorris
Copy link
Contributor

@piscisaureus The raw parts are still accessible through process.binding('v8');. Reason I left it out is because, IIRC, grabing GC statistics in the middle of GC is still dangerous.

@piscisaureus
Copy link
Contributor Author

Continues in #131

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants