N-API: Support for DataView #13926
Labels
node-api
Issues and PRs related to the Node-API.
Comments
This was referenced Jun 26, 2017
|
I'm working on this |
|
@shivanth are you still working on this? |
|
Yup |
|
I might be able to submit a PR this weekend |
shivanth
added a commit
to shivanth/node
that referenced
this issue
Jul 19, 2017
Basic support for Dataview is added by this commit. This is achieved by using three functions, napi_create_dataview(), napi_is_dataview() and napi_get_dataview_info(); Fixes: nodejs#13926
addaleax
pushed a commit
that referenced
this issue
Jul 27, 2017
Basic support for Dataview is added in this commit. This is achieved by using three functions, napi_create_dataview(), napi_is_dataview() and napi_get_dataview_info(). PR-URL: #14382 Fixes: #13926 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
gabrielschulhof
pushed a commit
to gabrielschulhof/node
that referenced
this issue
Apr 10, 2018
Basic support for Dataview is added in this commit. This is achieved by using three functions, napi_create_dataview(), napi_is_dataview() and napi_get_dataview_info(). PR-URL: nodejs#14382 Fixes: nodejs#13926 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this issue
Apr 16, 2018
Basic support for Dataview is added in this commit. This is achieved by using three functions, napi_create_dataview(), napi_is_dataview() and napi_get_dataview_info(). Backport-PR-URL: #19447 PR-URL: #14382 Fixes: #13926 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
N-API currently has APIs for
ArrayBufferandTypedArrayclasses, but not theDataViewclass. TheDataViewclass is specified by ES6 as another kind of view over anArrayBuffer.While it could be possible to extend (and rename?)
napi_create_typedarray()andnapi_get_typedarray_info()to also supportDataViewobjects, The combination would be too confusing, because aDataViewdoesn't have a type, and measures length in terms of bytes instead of elements. There should be separate APIs:napi_is_dataview()napi_create_dataview()napi_get_dataview_info()The N-API team will get to this based on priorities, but this is a good place for others to contribute as well. If you start working on this, assign the issue to yourself and add a comment that you are working on it.
The text was updated successfully, but these errors were encountered: