Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't extend encoding by hack Buffer.isEncoding anymore #1547

Closed
hefangshi opened this issue Apr 28, 2015 · 2 comments
Closed

Can't extend encoding by hack Buffer.isEncoding anymore #1547

hefangshi opened this issue Apr 28, 2015 · 2 comments
Labels
string_decoder Issues and PRs related to the string_decoder subsystem.

Comments

@hefangshi
Copy link
Contributor

a widely used iconv library iconv-lite can extend encoding by hack Buffer.isEncoding using extendNodeEncodings

but a newly commit 8a94581 cached the Buffer.isEncoding method https://github.com/iojs/io.js/blob/master/lib/string_decoder.js#L3-L9 which made extendNodeEncodings won't work.
@mscdex mscdex added the string_decoder Issues and PRs related to the string_decoder subsystem. label Apr 28, 2015
@Fishrock123
Copy link
Member

@mscdex Looks like that could be undone easily enough without any real downsides. You on it?

mscdex added a commit to mscdex/io.js that referenced this issue Apr 28, 2015
@mscdex
string_decoder: don't cache Buffer.isEncoding
b658db1 
Some modules are monkey-patching Buffer.isEncoding, so without this
they cannot do that.

Fixes: nodejs#1547
mscdex added a commit to mscdex/io.js that referenced this issue Apr 28, 2015
@mscdex
string_decoder: don't cache Buffer.isEncoding
afd3cc9 
Some modules are monkey-patching Buffer.isEncoding, so without this
they cannot do that.

Fixes: nodejs#1547
mscdex added a commit that referenced this issue Apr 28, 2015
@mscdex
string_decoder: don't cache Buffer.isEncoding
0fa6c4a 
Some modules are monkey-patching Buffer.isEncoding, so without this
they cannot do that.

Fixes: #1547
PR-URL: #1548
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@mscdex
Copy link
Contributor

mscdex commented Apr 28, 2015

Fixed in 0fa6c4a.

@mscdex mscdex closed this as completed Apr 28, 2015
Fishrock123 pushed a commit to Fishrock123/node that referenced this issue Apr 29, 2015
@mscdex @Fishrock123
string_decoder: don't cache Buffer.isEncoding
96ca599 
Some modules are monkey-patching Buffer.isEncoding, so without this
they cannot do that.

Fixes: nodejs#1547
PR-URL: nodejs#1548
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Fishrock123 pushed a commit to Fishrock123/node that referenced this issue May 14, 2015
@mscdex @Fishrock123
string_decoder: don't cache Buffer.isEncoding
898d423 
Some modules are monkey-patching Buffer.isEncoding, so without this
they cannot do that.

Fixes: nodejs#1547
PR-URL: nodejs#1548
PORT-PR-URL: nodejs#1560
PORT-FROM: v2.x / 0fa6c4a
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@Mithgol Mithgol mentioned this issue Sep 12, 2015
Closed
@snyk-bot snyk-bot mentioned this issue Jul 28, 2021
Open
This was referenced Jun 21, 2023
Open
Open
Open
Open
Open
Open
Open
Open
@adamlaska adamlaska mentioned this issue Jun 23, 2023
Open
@aliscco aliscco mentioned this issue Jun 24, 2023
Open
This was referenced Jul 6, 2023
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
string_decoder Issues and PRs related to the string_decoder subsystem.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mscdex @hefangshi @Fishrock123