Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test-http-writable-true-after-close failure on centos #15505

Closed
mhdawson opened this issue Sep 20, 2017 · 6 comments
Closed

test-http-writable-true-after-close failure on centos #15505

mhdawson opened this issue Sep 20, 2017 · 6 comments
Labels
http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests.

Comments

@mhdawson
Copy link
Member

mhdawson commented Sep 20, 2017 •
edited

  • Version: master
  • Platform: centos
  • Subsystem: http

I've seen a number of failures in runs today, including one that I started on master without any changes of:

https://ci.nodejs.org/job/node-test-commit-linux/12529/nodes=centos5-32/console
https://ci.nodejs.org/job/node-test-commit-linux/12525/nodes=centos5-64/console

not ok 751 parallel/test-http-writable-true-after-close
  ---
  duration_ms: 0.281
  severity: fail
  stack: |-
    Mismatched <anonymous> function calls. Expected exactly 1, actual 0.
        at Object.exports.mustCall (/home/iojs/build/workspace/node-test-commit-linux/nodes/centos5-32/test/common/index.js:482:10)
        at ClientRequest.common.mustCall (/home/iojs/build/workspace/node-test-commit-linux/nodes/centos5-32/test/parallel/test-http-writable-true-after-close.js:24:28)
        at ClientRequest.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux/nodes/centos5-32/test/common/index.js:514:15)
        at Object.onceWrapper (events.js:316:30)
        at emitOne (events.js:115:13)
        at ClientRequest.emit (events.js:210:7)
        at HTTPParser.parserOnIncomingClient [as onIncoming] (_http_client.js:565:21)
        at HTTPParser.parserOnHeadersComplete (_http_common.js:116:23)
        at Socket.socketOnData (_http_client.js:454:20)
  ...

So we may have landed something that broke that without noticing.
@mhdawson
Copy link
Member Author

I think this landed recently #15404

@mhdawson
Copy link
Member Author

@mcollina can you take a look to see if that change might be related ?

@mhdawson
Copy link
Member Author

Looks like the test failed in the CI run for that change as well.

@mcollina
Copy link
Member

Ouch, my bad. There are always some red for any number of reasons :/. I will have a look tomorrow, if you want you can revert now and I will merge again when it’s passing.

@mscdex mscdex added http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests. labels Sep 20, 2017
@mcollina mcollina mentioned this issue Sep 21, 2017
Closed
2 tasks
@mhdawson mhdawson mentioned this issue Sep 22, 2017
Closed
4 tasks
@mcollina
Copy link
Member

@mhdawson I'm stuck with that. I can't make that test pass on CentOS. Can someone else with more direct experience on the environment have a look? I do not know why it passes everywhere else and not there. The 'close'  event on 'OutgoingMessage'  is not fired there in that condition.

@apapirovski apapirovski mentioned this issue Sep 23, 2017
Closed
2 tasks
@Trott
Copy link
Member

Trott commented Sep 25, 2017

@mcollina On CentOS 5 (in CI at least), it is calling the finish event rather than the close event. Not sure if that information is helpful or not...

mcollina added a commit to mcollina/node that referenced this issue Sep 27, 2017
@mcollina
test: fix http-writable-true-after-close flakyness
dfd4c63 
Ref: nodejs#15404
Fixes: nodejs#15505
MylesBorins pushed a commit to MylesBorins/node that referenced this issue Sep 28, 2017
@mcollina @MylesBorins
test: fix http-writable-true-after-close flakyness
067c5e4 
Ref: nodejs#15404
Fixes: nodejs#15505
PR-URL: nodejs#15520
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@bnoordhuis bnoordhuis mentioned this issue Sep 28, 2017
Merged
MylesBorins pushed a commit that referenced this issue Sep 29, 2017
@mcollina @MylesBorins
test: fix http-writable-true-after-close flakyness
f2fde76 
Ref: #15404
Fixes: #15505
PR-URL: #15520
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit to addaleax/ayo that referenced this issue Sep 30, 2017
@mcollina @addaleax
test: fix http-writable-true-after-close flakyness
14c9585 
Ref: nodejs/node#15404
Fixes: nodejs/node#15505
PR-URL: nodejs/node#15520
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott Trott mentioned this issue Sep 30, 2017
Closed
MylesBorins pushed a commit that referenced this issue Oct 3, 2017
@mcollina @MylesBorins
test: fix http-writable-true-after-close flakyness
0aea258 
Ref: #15404
Fixes: #15505
PR-URL: #15520
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mcollina @mscdex @Trott @mhdawson