Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fatal error: 'node_internals.h' file not found #15552

Closed
AndreasMadsen opened this issue Sep 22, 2017 · 2 comments
Closed

fatal error: 'node_internals.h' file not found #15552

AndreasMadsen opened this issue Sep 22, 2017 · 2 comments
Assignees
@addaleax
Labels
addons Issues and PRs related to native addons. confirmed-bug Issues with confirmed bugs.

Comments

@AndreasMadsen
Copy link
Member

AndreasMadsen commented Sep 22, 2017 •
edited
Loading

  • Version: 01c680b
  • Platform: MacOS X
  • Subsystem: addon

Running npm --nodedir=$NODE_BUILD_PATH install native-hdr-histogram causes the error:

/Users/Andreas/node/include/node/node_buffer.h:25:10: fatal error: 'node_internals.h' file not found
#include "node_internals.h"

I think we did something wrong in how we export or setup the headers. It appears to be caused by 290315a
@AndreasMadsen
Copy link
Member Author

/cc @addaleax

@AndreasMadsen AndreasMadsen added the addons Issues and PRs related to native addons. label Sep 22, 2017
@richardlau
Copy link
Member

richardlau commented Sep 22, 2017 •
edited
Loading

Suspect 290315a is the culprit. The refactor appears to have dropped the #if defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS guard.

@richardlau richardlau mentioned this issue Sep 22, 2017
Merged
@addaleax addaleax self-assigned this Sep 22, 2017
addaleax added a commit to addaleax/node that referenced this issue Sep 22, 2017
@addaleax
src: do not include internals from node_buffer.h
6dcf62c 
`node_buffer.h` is a public header, so it should not be using
the `node_internals.h` internal header.

Ref: 290315a
Fixes: nodejs#15552
@addaleax addaleax mentioned this issue Sep 22, 2017
Closed
2 tasks
@AndreasMadsen AndreasMadsen added the confirmed-bug Issues with confirmed bugs. label Sep 22, 2017
addaleax added a commit to addaleax/ayo that referenced this issue Sep 23, 2017
@addaleax
src: do not include internals from node_buffer.h
df18f2a 
`node_buffer.h` is a public header, so it should not be using
the `node_internals.h` internal header.

Ref: 290315a
Fixes: nodejs/node#15552
PR-URL: nodejs/node#15554
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Andreas Madsen <amwebdk@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
jasnell pushed a commit that referenced this issue Sep 25, 2017
@addaleax @jasnell
src: do not include internals from node_buffer.h
24271a7 
`node_buffer.h` is a public header, so it should not be using
the `node_internals.h` internal header.

Ref: 290315a
Fixes: #15552
PR-URL: #15554
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Andreas Madsen <amwebdk@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@addaleax addaleax

Labels
addons Issues and PRs related to native addons. confirmed-bug Issues with confirmed bugs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

src: do not include internals from node_buffer.h addaleax/node
3 participants
@AndreasMadsen @addaleax @richardlau