Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSX: sequential/test-http-writable-true-after-close #16321

Closed
mhdawson opened this issue Oct 19, 2017 · 3 comments
Closed

OSX: sequential/test-http-writable-true-after-close #16321

mhdawson opened this issue Oct 19, 2017 · 3 comments
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. http Issues or PRs related to the http subsystem. macos Issues and PRs related to the macOS platform / OSX. test Issues and PRs related to the tests.

Comments

@mhdawson
Copy link
Member

mhdawson commented Oct 19, 2017

  • Version: master
  • Platform: OSX
  • Subsystem: http

https://ci.nodejs.org/job/node-test-commit-osx/13264/nodes=osx1010/console

not ok 1960 sequential/test-http-writable-true-after-close
  ---
  duration_ms: 0.138
  severity: fail
  stack: |-
    Mismatched <anonymous> function calls. Expected exactly 1, actual 0.
        at Object.exports.mustCall (/Users/iojs/build/workspace/node-test-commit-osx/nodes/osx1010/test/common/index.js:488:10)
        at ClientRequest.common.mustCall (/Users/iojs/build/workspace/node-test-commit-osx/nodes/osx1010/test/sequential/test-http-writable-true-after-close.js:16:29)
        at ClientRequest.<anonymous> (/Users/iojs/build/workspace/node-test-commit-osx/nodes/osx1010/test/common/index.js:520:15)
        at Object.onceWrapper (events.js:333:30)
        at emitOne (events.js:126:13)
        at ClientRequest.emit (events.js:224:7)
        at HTTPParser.parserOnIncomingClient [as onIncoming] (_http_client.js:550:21)
        at HTTPParser.parserOnHeadersComplete (_http_common.js:117:23)
        at Socket.socketOnData (_http_client.js:439:20)

Failed in CI run for test change that was not related.

@mscdex mscdex added http Issues or PRs related to the http subsystem. macos Issues and PRs related to the macOS platform / OSX. test Issues and PRs related to the tests. labels Oct 19, 2017
@Ethan-Arrowood
Copy link
Contributor

What is the scope of this issue? With a little more explanation and guidance I'd love to try to resolve it.

@apapirovski
Copy link
Member

@Ethan-Arrowood I'm not certain anyone truly knows since that test seems to exhibit pretty highly divergent behaviour between different systems. I'll ping @mcollina though who worked on it last and maybe he can offer some guidance.

@mcollina
Copy link
Member

That test has been highly flaky but it tests some needed things. I've worked extensively on it without finding a good solution to make it less flaky. IMHO it might hide some sporadic bug beneath.

@maclover7 maclover7 added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Dec 31, 2017
MylesBorins pushed a commit that referenced this issue Jan 8, 2018
PR-URL: #17952
Fixes: #16321
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this issue Jan 9, 2018
PR-URL: #17952
Fixes: #16321
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this issue Jan 9, 2018
PR-URL: #17952
Fixes: #16321
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this issue Jan 24, 2018
PR-URL: #17952
Fixes: #16321
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. http Issues or PRs related to the http subsystem. macos Issues and PRs related to the macOS platform / OSX. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants