Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

intermittent? parallel/test-http2-session-unref failure on sharedlibs debug #18587

Closed
mhdawson opened this issue Feb 5, 2018 · 0 comments
Closed

intermittent? parallel/test-http2-session-unref failure on sharedlibs debug #18587

mhdawson opened this issue Feb 5, 2018 · 0 comments
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. http2 Issues or PRs related to the http2 subsystem. test Issues and PRs related to the tests.

Comments

@mhdawson
Copy link
Member

mhdawson commented Feb 5, 2018

  • Version: master
  • Platform: ubuntu1604_sharedlibs_debug
  • Subsystem: http2

https://ci.nodejs.org/job/node-test-commit-linux-containered/1965/nodes=ubuntu1604_sharedlibs_debug_x64/console

11:01:46 not ok 1025 parallel/test-http2-session-unref
11:01:46   ---
11:01:46   duration_ms: 9.18
11:01:46   severity: fail
11:01:46   stack: |-
11:01:46     (node:12269) ExperimentalWarning: The http2 module is an experimental API.
11:01:46     assert.js:74
11:01:46       throw new AssertionError(obj);
11:01:46       ^
11:01:46     
11:01:46     AssertionError [ERR_ASSERTION]: () => {} at /home/iojs/build/workspace/node-test-commit-linux-containered/nodes/ubuntu1604_sharedlibs_debug_x64/test/parallel/test-http2-session-unref.js:53
11:01:46         at Timeout.mustNotCall (/home/iojs/build/workspace/node-test-commit-linux-containered/nodes/ubuntu1604_sharedlibs_debug_x64/test/common/index.js:539:12)
11:01:46         at ontimeout (timers.js:438:11)
11:01:46         at Timer.unrefdHandle (timers.js:524:7)
11:01:46   ...
@mhdawson mhdawson changed the title intermittent? parallel/test-http2-session-unref failre on sharedlibs debug intermittent? parallel/test-http2-session-unref failure on sharedlibs debug Feb 5, 2018
@mhdawson mhdawson mentioned this issue Feb 5, 2018
Closed
3 tasks
@maclover7 maclover7 added test Issues and PRs related to the tests. flaky-test Issues and PRs related to the tests with unstable failures on the CI. http2 Issues or PRs related to the http2 subsystem. labels Feb 5, 2018
@apapirovski apapirovski mentioned this issue Feb 5, 2018
Closed
3 tasks
MylesBorins pushed a commit that referenced this issue Feb 21, 2018
@apapirovski @MylesBorins
test: fix flaky test-http2-session-unref
298ee05 
This test should exit naturally or will timeout on its own,
a separate unrefed timer is not necessary.

PR-URL: #18589
Fixes: #18587
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this issue Feb 21, 2018
@apapirovski @MylesBorins
test: fix flaky test-http2-session-unref
102dac8 
This test should exit naturally or will timeout on its own,
a separate unrefed timer is not necessary.

PR-URL: #18589
Fixes: #18587
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this issue Feb 21, 2018
@apapirovski @MylesBorins
test: fix flaky test-http2-session-unref
30a233c 
This test should exit naturally or will timeout on its own,
a separate unrefed timer is not necessary.

PR-URL: #18589
Fixes: #18587
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MayaLekova pushed a commit to MayaLekova/node that referenced this issue May 8, 2018
@apapirovski @MayaLekova
test: fix flaky test-http2-session-unref
3ed17c5 
This test should exit naturally or will timeout on its own,
a separate unrefed timer is not necessary.

PR-URL: nodejs#18589
Fixes: nodejs#18587
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. http2 Issues or PRs related to the http2 subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: fix flaky test-http2-session-unref apapirovski/node
2 participants
@maclover7 @mhdawson