Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky test-repl-timeout-throw #18659

Closed
BridgeAR opened this issue Feb 8, 2018 · 0 comments
Closed

Flaky test-repl-timeout-throw #18659

BridgeAR opened this issue Feb 8, 2018 · 0 comments
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. repl Issues and PRs related to the REPL subsystem. test Issues and PRs related to the tests.

Comments

@BridgeAR
Copy link
Member

BridgeAR commented Feb 8, 2018

https://ci.nodejs.org/job/node-test-commit-linux-containered/1871/nodes=ubuntu1604_sharedlibs_debug_x64/console

11:07:54 not ok 2050 sequential/test-repl-timeout-throw
11:07:54   ---
11:07:54   duration_ms: 5.146
11:07:54   severity: fail
11:07:54   stack: |-
11:07:54     > ''
11:07:54     > THROW 0
11:07:54     ReferenceError: XXX is not defined
11:07:54         at Timeout.thrower [as _onTimeout] (repl:1:116)
11:07:54         at ontimeout (timers.js:458:11)
11:07:54         at tryOnTimeout (timers.js:307:5)
11:07:54         at Timer.listOnTimeout (timers.js:270:5)
11:07:54     > undefined
11:07:54     > ... ... ... ..... ..... ....... ....... ..... ... ''
11:07:54     > THROW 1
11:07:54     ReferenceError: XXX is not defined
11:07:54         at EventEmitter.thrower (repl:1:116)
11:07:54         at EventEmitter.emit (events.js:131:13)
11:07:54         at EventEmitter.emit (domain.js:439:23)
11:07:54     > 2
11:07:54     var throws = 0;process.on("exit",function(){console.log(throws)});function thrower(){console.log("THROW",throws++);XXX};setTimeout(thrower);""
11:07:54     fs.readFile("/home/iojs/build/workspace/node-test-commit-linux-containered/nodes/ubuntu1604_sharedlibs_debug_x64/test/sequential/test-repl-timeout-throw.js", thrower);
11:07:54     setTimeout(function() {
11:07:54       const events = require("events");
11:07:54       var e = new events.EventEmitter;
11:07:54       process.nextTick(function() {
11:07:54         e.on("x", thrower);
11:07:55         setTimeout(function() {
11:07:55           e.emit("x");
11:07:55         });
11:07:55       });
11:07:55     });"";
11:07:55     assert.js:72
11:07:55       throw new AssertionError(obj);
11:07:55       ^
11:07:55     
11:07:55     AssertionError [ERR_ASSERTION]: '> 2' strictEqual '> 3'
11:07:55         at ChildProcess.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux-containered/nodes/ubuntu1604_sharedlibs_debug_x64/test/sequential/test-repl-timeout-throw.js:58:10)
11:07:55         at ChildProcess.emit (events.js:131:13)
11:07:55         at maybeClose (internal/child_process.js:946:16)
11:07:55         at Process.ChildProcess._handle.onexit (internal/child_process.js:220:5)
@BridgeAR BridgeAR added repl Issues and PRs related to the REPL subsystem. test Issues and PRs related to the tests. flaky-test Issues and PRs related to the tests with unstable failures on the CI. labels Feb 8, 2018
santigimeno added a commit to santigimeno/node that referenced this issue Feb 10, 2018
Don't disconnect the child until all exceptions are thrown.

Fixes: nodejs#18659
MylesBorins pushed a commit that referenced this issue Feb 21, 2018
Don't disconnect the child until all exceptions are thrown.

Fixes: #18659

PR-URL: #18692
Fixes: #18659
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this issue Feb 21, 2018
Don't disconnect the child until all exceptions are thrown.

Fixes: #18659

PR-URL: #18692
Fixes: #18659
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this issue Feb 21, 2018
Don't disconnect the child until all exceptions are thrown.

Fixes: #18659

PR-URL: #18692
Fixes: #18659
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this issue Feb 21, 2018
Don't disconnect the child until all exceptions are thrown.

Fixes: #18659

PR-URL: #18692
Fixes: #18659
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MayaLekova pushed a commit to MayaLekova/node that referenced this issue May 8, 2018
Don't disconnect the child until all exceptions are thrown.

Fixes: nodejs#18659

PR-URL: nodejs#18692
Fixes: nodejs#18659
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this issue Aug 7, 2018
Don't disconnect the child until all exceptions are thrown.

Fixes: #18659

PR-URL: #18692
Fixes: #18659
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
rvagg pushed a commit that referenced this issue Aug 16, 2018
Don't disconnect the child until all exceptions are thrown.

Fixes: #18659

PR-URL: #18692
Fixes: #18659
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. repl Issues and PRs related to the REPL subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant