http: client request doesn't always emit aborted when aborted
#20101
Labels
http
Issues or PRs related to the http subsystem.
Comments
ronag
added a commit
to nxtedition/node
that referenced
this issue
Apr 27, 2018
Fixes: nodejs#20102 Fixes: nodejs#20101 Fixes: nodejs#1735 - Response should always emit close. - Response should always emit aborted if aborted. - Response should always emit close after request has emitted close.
addaleax
pushed a commit
that referenced
this issue
May 14, 2018
Fixes: #20102 Fixes: #20101 Fixes: #1735 - Response should always emit close. - Response should always emit aborted if aborted. - Response should always emit close after request has emitted close. PR-URL: #20075 Fixes: #17352 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
A
http.ClientRequestwhich has received a response but the socket is closed before the response becomes readable will not emit anabortedevent on the response object nor a hang up error on the request object.See, 52da0a9 and #20075
The text was updated successfully, but these errors were encountered: