Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling of stray jobs that need terminating in CI #20194

Closed
Trott opened this issue Apr 21, 2018 · 0 comments
Closed

Better handling of stray jobs that need terminating in CI #20194

Trott opened this issue Apr 21, 2018 · 0 comments
Labels
build Issues and PRs related to build files or the CI. flaky-test Issues and PRs related to the tests with unstable failures on the CI.

Comments

@Trott
Copy link
Member

Trott commented Apr 21, 2018

This has recently started happening a lot in the macOS hosts in CI:

Some test times out. For example, in https://ci.nodejs.org/job/node-test-commit-osx/nodes=osx1010/17983/console, sequential/test-benchmark-http times out.

As a result, a stray subprocess is left that ends up causing subsequent jobs to fail. So, for example, https://ci.nodejs.org/job/node-test-commit-osx/nodes=osx1010/17988/console:

# Clean up any leftover processes, error if found.
ps awwx | grep Release/node | grep -v grep | cat
79201   ??  R    145:42.29 /Users/iojs/build/workspace/node-test-commit-osx/nodes/osx1010/out/Release/node /Users/iojs/build/workspace/node-test-commit-osx/nodes/osx1010/benchmark/http/cluster.js c=1 len=1 type=asc benchmarker=test-double chunkedEnc=true chunks=0 dur=0.1 key="" method=write n=1 res=normal
make[1]: *** [test-ci] Error 1

To fix this, someone from the Build WG (in this specific case, me) logs in and does a kill -9 on the PID. In theory, the PID should have been terminated by one of the instances of xargs kill that appears in the Makefile. My guess (that I keep forgetting to test when this comes up) is that the problem is that xargs kill needs to be xargs kill -9 to be effective in these cases on the macOS hosts.

@Trott Trott added build Issues and PRs related to build files or the CI. flaky-test Issues and PRs related to the tests with unstable failures on the CI. labels Apr 21, 2018
Trott added a commit to Trott/io.js that referenced this issue Apr 21, 2018
@Trott Trott closed this as completed in 7424d86 Apr 24, 2018
MylesBorins pushed a commit that referenced this issue May 4, 2018
Fixes: #20194

PR-URL: #20195
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. flaky-test Issues and PRs related to the tests with unstable failures on the CI.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant