Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix flaky test-fs-stat-bigint #21948

Closed
Trott opened this issue Jul 23, 2018 · 1 comment
Closed

fix flaky test-fs-stat-bigint #21948

Trott opened this issue Jul 23, 2018 · 1 comment
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests.

Comments

@Trott
Copy link
Member

Trott commented Jul 23, 2018

  • Version: v11.0.0-pre (master)
  • Platform: macOS but probably all
  • Subsystem: test

test-fs-stat-bigint is flaky due to side effects. One test case can affect the outcome of another test case. @samarthgulati is working on a fix. This is just here to document some stuff until they get a PR in, hopefully in the next hour or so.
@Trott Trott added fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests. flaky-test Issues and PRs related to the tests with unstable failures on the CI. labels Jul 23, 2018
@Trott
Copy link
Member Author

Trott commented Jul 23, 2018

When the previous stress test finishes, https://ci.nodejs.org/job/node-stress-single-test/1971/ will be the URL for a stress test that will (hopefully) show the flakiness.

samarthgulati pushed a commit to samarthgulati/node that referenced this issue Jul 23, 2018
test: fix unreliable test-fs-stat-bigint
be41186 
Remove side-effects between testcases by creating a new file everytime.

Fixes: nodejs#21948
@samarthgulati samarthgulati mentioned this issue Jul 23, 2018
Closed
2 tasks
@Trott Trott closed this as completed in 4d94bb2 Jul 25, 2018
targos pushed a commit that referenced this issue Jul 26, 2018
@targos
test: fix unreliable test-fs-stat-bigint
af6b824 
Remove side-effects between testcases by creating a new file everytime.

Fixes: #21948
PR-URL: #21949
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: fix unreliable test-fs-stat-bigint samarthgulati/node
1 participant
@Trott