Investigate flaky test-http-client-timeout-option-with-agent

[oyyd]

• Version: v11.0.0-pre(master)
• Platform: ubuntu1604_sharedlibs_debug_x64
• Subsystem: test

https://ci.nodejs.org/job/node-test-commit-linux-containered/5882/nodes=ubuntu1604_sharedlibs_debug_x64/console

11:15:20 not ok 833 parallel/test-http-client-timeout-option-with-agent
11:15:20   ---
11:15:20   duration_ms: 17.334
11:15:20   severity: fail
11:15:20   exitcode: 1
11:15:20   stack: |-
11:15:20     assert.js:84
11:15:20       throw new AssertionError(obj);
11:15:20       ^
11:15:20     
11:15:20     AssertionError [ERR_ASSERTION]: Input A expected to strictly equal input B:
11:15:20     + expected - actual
11:15:20     
11:15:20     - 4
11:15:20     + 3
11:15:20         at ClientRequest.req.on.common.mustCall (/home/iojs/build/workspace/node-test-commit-linux-containered/nodes/ubuntu1604_sharedlibs_debug_x64/test/parallel/test-http-client-timeout-option-with-agent.js:46:12)
11:15:20         at ClientRequest.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux-containered/nodes/ubuntu1604_sharedlibs_debug_x64/test/common/index.js:467:15)
11:15:20         at ClientRequest.emit (events.js:182:13)
11:15:20         at Socket.emitRequestTimeout (_http_client.js:669:40)
11:15:20         at Object.onceWrapper (events.js:273:13)
11:15:20         at Socket.emit (events.js:182:13)
11:15:20         at Socket._onTimeout (net.js:448:8)
11:15:20         at ontimeout (timers.js:454:11)
11:15:20         at tryOnTimeout (timers.js:326:5)
11:15:20         at listOnTimeout (timers.js:300:5)
11:15:20   ...

This test asserts the elapsed time of timeout in second units. But the actual timeout may be longer in some situations.

It seems that other related tests avoid measuring the elapsed time. I would like to modify this test to make it less likely fail and keep the consistency of these tests.

[Trott]

The main cause of failure here is almost certainly that it's a debug build, which makes everything run slooooowwwwer.....

[Trott]

Alas, still flaky.

https://ci.nodejs.org/job/node-test-commit-linux-containered/6421/nodes=ubuntu1604_sharedlibs_shared_x64/console

00:15:46 not ok 2230 sequential/test-http-client-timeout-option-with-agent
00:15:46   ---
00:15:46   duration_ms: 5.26
00:15:46   severity: fail
00:15:46   exitcode: 1
00:15:46   stack: |-
00:15:46     assert.js:84
00:15:46       throw new AssertionError(obj);
00:15:46       ^
00:15:46     
00:15:46     AssertionError [ERR_ASSERTION]: Expected inputs to be strictly equal:
00:15:46     
00:15:46     4 !== 3
00:15:46     
00:15:46         at ClientRequest.req.on.common.mustCall (/home/iojs/build/workspace/node-test-commit-linux-containered/nodes/ubuntu1604_sharedlibs_shared_x64/test/sequential/test-http-client-timeout-option-with-agent.js:46:12)
00:15:46         at ClientRequest.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux-containered/nodes/ubuntu1604_sharedlibs_shared_x64/test/common/index.js:460:15)
00:15:46         at ClientRequest.emit (events.js:182:13)
00:15:46         at Socket.emitRequestTimeout (_http_client.js:670:40)
00:15:46         at Object.onceWrapper (events.js:273:13)
00:15:46         at Socket.emit (events.js:182:13)
00:15:46         at Socket._onTimeout (net.js:449:8)
00:15:46         at ontimeout (timers.js:454:11)
00:15:46         at tryOnTimeout (timers.js:326:5)
00:15:46         at listOnTimeout (timers.js:300:5)
00:15:46   ...

[Trott]

Proposed fix in #22403