Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs missing for http2Stream.id and the 'ready' event #22804

Closed
jakearchibald opened this issue Sep 11, 2018 · 4 comments
Closed

Docs missing for http2Stream.id and the 'ready' event #22804

jakearchibald opened this issue Sep 11, 2018 · 4 comments
Labels
doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors. help wanted Issues that need assistance from volunteers or PRs that need help to proceed. http2 Issues or PRs related to the http2 subsystem.

Comments

@jakearchibald
Copy link

I wrote a piece of code that made a request to A, and after a moment, made a request to B with the prior stream as a parent.

This means I needed to pass the ID of stream A to the client.request call for stream B.

stream.id is mentioned in passing, but it isn't specifically documented.

Same goes for the ready event.
@Trott
Copy link
Member

Trott commented Nov 4, 2018

@nodejs/documentation @nodejs/http2

@ryzokuken
Copy link
Contributor

I tried to do something like this in nodejs/help#877 (comment), but was stalled. Perhaps we could break these into a couple of "good second issue"s?

@ryzokuken
Copy link
Contributor

/cc @mcollina

@mcollina
Copy link
Member

mcollina commented Nov 4, 2018

stream.id is the HTTP2 Stream id.

ready is emitted when an id is available.

@jasnell jasnell added doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem. good first issue Issues that are suitable for first-time contributors. help wanted Issues that need assistance from volunteers or PRs that need help to proceed. labels Jun 26, 2020
jasnell added a commit to jasnell/node that referenced this issue Jul 6, 2020
@jasnell
doc: document the ready event for Http2Stream
56bb548 
Fixes: nodejs#22804
@jasnell jasnell mentioned this issue Jul 6, 2020
Closed
3 tasks
@jasnell jasnell closed this as completed in f98a441 Jul 9, 2020
MylesBorins pushed a commit that referenced this issue Jul 14, 2020
@jasnell @MylesBorins
doc: document the ready event for Http2Stream
fadc5f8 
Fixes: #22804

PR-URL: #34221
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins pushed a commit that referenced this issue Jul 16, 2020
@jasnell @MylesBorins
doc: document the ready event for Http2Stream
9339f9f 
Fixes: #22804

PR-URL: #34221
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
addaleax pushed a commit that referenced this issue Sep 22, 2020
@jasnell @addaleax
doc: document the ready event for Http2Stream
5ce4935 
Fixes: #22804

PR-URL: #34221
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
addaleax pushed a commit that referenced this issue Sep 22, 2020
@jasnell @addaleax
doc: document the ready event for Http2Stream
2615e55 
Fixes: #22804

PR-URL: #34221
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors. help wanted Issues that need assistance from volunteers or PRs that need help to proceed. http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: document the ready event for Http2Stream jasnell/node
5 participants
@mcollina @jakearchibald @jasnell @Trott @ryzokuken