Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V8 gyp file refactor performance regression #23796

Closed
addaleax opened this issue Oct 21, 2018 · 1 comment · Fixed by #23801
Closed

V8 gyp file refactor performance regression #23796

addaleax opened this issue Oct 21, 2018 · 1 comment · Fixed by #23801
Labels
build Issues and PRs related to build files or the CI. performance Issues and PRs related to the performance of Node.js. regression Issues related to regressions. v8 engine Issues and PRs related to the V8 dependency.

Comments

@addaleax
Copy link
Member

Since #23182, we build V8 in Release mode with -DENABLE_HANDLE_ZAPPING. This should only be enabled in debug mode.

I’ve only noticed this because it’s started to show up as 2 % runtime overhead in benchmarks – I’m not familiar enough with GYP to address this myself.

@refack @nodejs/build-files
@addaleax addaleax added build Issues and PRs related to build files or the CI. v8 engine Issues and PRs related to the V8 dependency. v10.x performance Issues and PRs related to the performance of Node.js. regression Issues related to regressions. labels Oct 21, 2018
@refack refack mentioned this issue Oct 21, 2018
Merged
3 tasks
@refack
Copy link
Contributor

refack commented Oct 21, 2018

Fix in #23801

refack added a commit to refack/node that referenced this issue Oct 23, 2018
@refack
deps: fix wrong default for v8 handle zapping
c9b49a6 
PR-URL: nodejs#23801
Fixes: nodejs#23796
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
targos pushed a commit that referenced this issue Oct 24, 2018
@refack @targos
deps: fix wrong default for v8 handle zapping
3b66a8d 
PR-URL: #23801
Fixes: #23796
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
MylesBorins pushed a commit that referenced this issue Oct 25, 2018
@refack @MylesBorins
deps: fix wrong default for v8 handle zapping
1003f4c 
PR-URL: #23801
Fixes: #23796
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. performance Issues and PRs related to the performance of Node.js. regression Issues related to regressions. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

deps: fix wrong default for v8 handle zapping refack/node
2 participants
@refack @addaleax