Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run tests with OPENSSL_CONF set to embedded openssl.cnf #24373

Open
kapouer opened this issue Nov 15, 2018 · 2 comments
Open

Run tests with OPENSSL_CONF set to embedded openssl.cnf #24373

kapouer opened this issue Nov 15, 2018 · 2 comments
Labels
help wanted Issues that need assistance from volunteers or PRs that need help to proceed. openssl Issues and PRs related to the OpenSSL dependency. test Issues and PRs related to the tests.

Comments

@kapouer
Copy link
Contributor

kapouer commented Nov 15, 2018

  • Version: <= 10.13.0
  • Platform: Linux

when building with the --shared-openssl flag, it is highly probable that the openssl.cnf used by the shared library will be different than the one present in Node.js source code, resulting in several test failures.
Typically, on debian, openssl is configured with stricter options regarding key length and TLS versions.
It is very easy to avoid any test failure, though, by setting this environment variable when running tests:
OPENSSL_CONF=./deps/openssl/openssl/apps/openssl.cnf
@bnoordhuis bnoordhuis added test Issues and PRs related to the tests. openssl Issues and PRs related to the OpenSSL dependency. labels Nov 15, 2018
@bnoordhuis
Copy link
Member

Pull request welcome. There's already code in test/testpy/__init__.py that parses config.gypi and can be extended to also look at the node_shared_openssl variable.

kapouer added a commit to kapouer/node that referenced this issue Nov 15, 2018
@kapouer
test: use openssl.cnf if using shared openssl
5583ead 
Fix nodejs#24373
@kapouer kapouer mentioned this issue Nov 15, 2018
Closed
@Trott
Copy link
Member

Trott commented Nov 15, 2018

/ping @danbev

HarshithaKP added a commit to HarshithaKP/node that referenced this issue Apr 15, 2020
@HarshithaKP @kapouer
test: use openssl.cnf for shared openssl
52e9905 
Fixes: nodejs#24373

Co-authored-by: Jérémy Lal <kapouer@melix.org>
@HarshithaKP HarshithaKP mentioned this issue Apr 15, 2020
Closed
4 tasks
@jasnell jasnell added the help wanted Issues that need assistance from volunteers or PRs that need help to proceed. label Jun 26, 2020
@nodejs nodejs deleted a comment Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Issues that need assistance from volunteers or PRs that need help to proceed. openssl Issues and PRs related to the OpenSSL dependency. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
4 participants
@kapouer @bnoordhuis @jasnell @Trott