Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http/2 compat HEAD always finished #24743

Closed
ronag opened this issue Nov 30, 2018 · 2 comments
Closed

http/2 compat HEAD always finished #24743

ronag opened this issue Nov 30, 2018 · 2 comments
Labels
http2 Issues or PRs related to the http2 subsystem.

Comments

@ronag
Copy link
Member

ronag commented Nov 30, 2018

i.e. this breaks for HEAD requests:

server.on('request', (req, res) => {
  assert(!res.finished) // Fail
  res.end()
})
@ronag ronag mentioned this issue Nov 30, 2018
Closed
4 tasks
This was referenced Jun 8, 2019
Closed
Closed
ronag added a commit that referenced this issue Feb 18, 2020
@ronag
http2: make compat finished match http/1
8ba7a2f 
finished should true directly after end().

PR-URL: #24347
Refs: #24743
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere pushed a commit that referenced this issue Feb 27, 2020
@ronag @codebytere
http2: make compat finished match http/1
9079bb4 
finished should true directly after end().

PR-URL: #24347
Refs: #24743
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere pushed a commit that referenced this issue Mar 15, 2020
@ronag @codebytere
http2: make compat finished match http/1
6aca5f9 
finished should true directly after end().

PR-URL: #24347
Refs: #24743
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere pushed a commit that referenced this issue Mar 17, 2020
@ronag @codebytere
http2: make compat finished match http/1
3a77c7e 
finished should true directly after end().

PR-URL: #24347
Refs: #24743
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere pushed a commit that referenced this issue Mar 30, 2020
@ronag @codebytere
http2: make compat finished match http/1
76a0ba6 
finished should true directly after end().

PR-URL: #24347
Refs: #24743
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell jasnell added the http2 Issues or PRs related to the http2 subsystem. label Jun 26, 2020
@jasnell
Copy link
Member

jasnell commented Jun 26, 2020

@ronag is this still an issue?

@ronag
Copy link
Member Author

ronag commented Jun 26, 2020

I think this was fixed in #24347

@ronag ronag closed this as completed Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jasnell @ronag