Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node-tap failing on master #28294

Closed
mcollina opened this issue Jun 19, 2019 · 3 comments
Closed

node-tap failing on master #28294

mcollina opened this issue Jun 19, 2019 · 3 comments

Comments

@mcollina
Copy link
Member

  • Version: master
  • Platform: all
  • Subsystem: module

CITGM is currently failing on master due to some changes in the CJS module loader, because it breaks the https://www.node-tap.org/ test framework:

       > pre-commit@1.2.2 install /data/iojs/build/workspace/citgm-smoker/nodes/rhel72-s390x/citgm_tmp/504cfd89-cd8f-4fe5-bed1-457eddba69b4/split2/node_modules/pre-commit
 > node install.js
 > spawn-sync@1.0.15 postinstall /data/iojs/build/workspace/citgm-smoker/nodes/rhel72-s390x/citgm_tmp/504cfd89-cd8f-4fe5-bed1-457eddba69b4/split2/node_modules/spawn-sync
 > node postinstall
 added 450 packages from 242 contributors and audited 1033 packages in 7.233s
 found 0 vulnerabilities
 > split2@3.1.1 test /data/iojs/build/workspace/citgm-smoker/nodes/rhel72-s390x/citgm_tmp/504cfd89-cd8f-4fe5-bed1-457eddba69b4/split2
 > standard && tap -b test.js
 TAP version 13
 # Subtest: test.js
     1..0 # no tests found
 not ok 1 - test.js # time=116.868ms
   ---
   timeout: 30000
   file: test.js
   childId: 0
   command: /data/iojs/build/workspace/citgm-smoker/nodes/rhel72-s390x/smoker/bin/node
   args:
     - '-r'
     - >-
       /data/iojs/build/workspace/citgm-smoker/nodes/rhel72-s390x/citgm_tmp/504cfd89-cd8f-4fe5-bed1-457eddba69b4/split2/node_modules/esm/esm.js
     - test.js
   stdio:
     - 0
     - pipe
     - 2
   cwd: >-
     /data/iojs/build/workspace/citgm-smoker/nodes/rhel72-s390x/citgm_tmp/504cfd89-cd8f-4fe5-bed1-457eddba69b4/split2
   exitCode: 1
   ...
 Bail out! # test.js
 TypeError: Function.prototype.apply was called on undefined, which is a undefined and not a function
     at internal/main/run_main_module.js:17:11
 npm ERR! Test failed.  See above for more details.
@mcollina
Copy link
Member Author

mcollina commented Jun 19, 2019

Note that this is due to some incompatibility with esm. @jdalton maybe you can take a look?

(running tap with --no-esm fixes the problem, but it's enabled by default).

@targos
Copy link
Member

targos commented Jun 19, 2019

It's a bug in esm. I already opened standard-things/esm#821

@targos
Copy link
Member

targos commented Jun 19, 2019

It's not related to the module loader btw, just a change in the prototype chain of fs.Stats.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants